Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire up limit orders UI to RTK query #8052

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

woodenfurniture
Copy link
Member

Description

Wires up part of the limit orders ui to RTK for limit order quotes. Note that the quotes provide a market rate only and do not actually return any relevant info in terms of limit orders.

Also note that receive address will have to be implement as a separate task as it's likely much more involved than estimated in this ticked.

Further wiring to come in follow-ups.

Issue (if applicable)

closes #8032

Risk

High Risk PRs Require 2 approvals

Very very low risk, not user facing.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

Check that a limit order quote (or an error) appears in the terminal per the console logs when getting a quote.

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image

@woodenfurniture woodenfurniture requested a review from a team as a code owner October 31, 2024 01:52
@0xApotheosis
Copy link
Contributor

@woodenfurniture CI sad ser

Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the box!

Screenshot 2024-11-01 at 10 28 23

src/state/apis/limit-orders/limitOrderApi.ts Show resolved Hide resolved
@0xApotheosis 0xApotheosis merged commit 587784e into develop Oct 31, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the limit-orders-rtk-query branch October 31, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wire up input UI to RTK query
2 participants