fix: send not enough funds error handling at submit time #8076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeOMakinG
commented
Nov 4, 2024
woodenfurniture
approved these changes
Nov 4, 2024
| const feeAsset = selectFeeAssetById(store.getState(), feeAssetId ?? '') | ||
|
|
||
| // @TODO: as this is the first time we are handling errors from unchained in this scope, we dont have a complete error handling strategy | ||
| // If we need to handle more errors, we should create a proper error handler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you first encounter low gas fees when opening the send modal, you might have the button as valid
If you wait like 1 mins, the fast fees might be > as what you had 1 min before, but you can continue
Then an error happens (with native, it says "Error cancelled the request"), which is wrong because the TX has been cancelled due to not enough balance to pay gas fees
Issue (if applicable)
partially #8035
Risk
Low
Testing
Monkey patch in
useSendDetails:Or, have a very low fee asset balance, like 0.005 POL for example, sometime it's enough, then sometime not, try to find the perfect time (almost impossible, I had it one time in 30 mins)
Engineering
n/a
Operations
n/a
Screenshots (if applicable)