Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: market filters going out of screen #8091

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

NeOMakinG
Copy link
Collaborator

Description

Market chain selector is going out of screen on mobile

Issue (if applicable)

closes #8090

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Open market category page on mobile
Select the avalanche chain, it should be displayed properly without any bugs

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

image
image
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner November 6, 2024 22:02
@NeOMakinG NeOMakinG marked this pull request as draft November 6, 2024 22:03
@NeOMakinG NeOMakinG marked this pull request as ready for review November 6, 2024 22:23
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tidy, fixes both the chain selector and the dropdown arrow issue too! 🫡

@0xApotheosis 0xApotheosis merged commit 41fda1b into develop Nov 7, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the bug-chain-select branch November 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants