Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation for multiple files #8101

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Nov 7, 2024

Added typo corrections to documentation for the following files

shapeshift-web/blob/develop/docs/asset-generation.md

typo in the text:

set is as an environment variable" should be "set it as an environment variable" (use "it" instead of "is").

Corrected.

shapeshift-web/edit/develop/docs/file-structure.md

"a hand full of props" should be "a handful of props". The phrase "handful" is the correct form.

Corrected.

shapeshift-web/blob/develop/docs/styles.md

"can not" should be "cannot" (it's generally preferred to write "cannot" as a single word).

Corrected.

shapeshift-web/edit/develop/src/assets/translations/ru/main.json

Typos have been identified and corrected.

Goal

Correct grammatical errors and improve readability of the documentation.

Typo in the text:

set is as an environment variable" should be "set it as an environment variable" (used "it" instead of "is").

Corrected.
"a hand full of props" should be "a handful of props". The phrase "handful" is the correct form.

Corrected.
"can not" should be "cannot" (it's generally preferred to write "cannot" as a single word).

Corrected.
Typos have been identified and corrected.
@mdqst mdqst requested a review from a team as a code owner November 7, 2024 17:40
@firebomb1
Copy link
Contributor

firebomb1 commented Nov 7, 2024

Thanks for the Russian translation suggestions @mdqst!

As we use a third-party platform to do the translation work (Gitlocalize), could you please revert this commit and I will submit them to our Russian translator for review during the next biweekly translation sync. Thanks in advance!

EDIT: If you have more translation suggestions or want to volunteer for reviews (we don't have a budget for reviews currently), feel free to message me on Discord (same username).

@0xApotheosis 0xApotheosis marked this pull request as draft November 7, 2024 23:12
@0xApotheosis 0xApotheosis changed the title Fix typos in documentation for multiple files fix: typos in documentation for multiple files Nov 8, 2024
@0xApotheosis 0xApotheosis marked this pull request as ready for review November 8, 2024 01:34
@0xApotheosis
Copy link
Contributor

@0xApotheosis 0xApotheosis enabled auto-merge (squash) November 8, 2024 01:35
@0xApotheosis 0xApotheosis merged commit c5b58f9 into shapeshift:develop Nov 8, 2024
2 of 3 checks passed
@firebomb1
Copy link
Contributor

Thanks for the merge!

@mdqst I was able to reach our Russian translator for a quick review, but as suggested above, if you have more changes/suggestions for any language feel free to reach to me on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants