Typo Corrections testing.md / README.md #8107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed account comparison in tests
Enclosed the account address in quotes to ensure it's treated as a string:
Changed expect(account).toEqual(0xa44c286ba83bb771cd0107b2c1df678435bd1535) to expect(account).toEqual('0xa44c286ba83bb771cd0107b2c1df678435bd1535')
- Removed the duplicate "react testing library" link.
- Corrected the test name in `useIsComponentMounted` to `it('should be false on unmount', ...)`.
- Replaced `data` with `UserData` in the `mockUserData` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several documentation updates and code fixes to improve code quality and readability. Specifically:
testing.mdandREADME.mdto ensure documentation accuracy.mockAxiosin test files to returnUserdatainstead ofdata, matching expected types and improving test reliability.caip/README.mdto ensure consistent naming, reducing potential confusion for developers referencing the documentation.Risk
This PR is categorized as low risk, as it primarily involves updates to documentation and test configurations. No on-chain transactions or core state management changes are introduced. These changes do not impact any production code directly but improve test readability and consistency.
None.
Engineering
To verify these changes:
mockAxiosreturn values.README.mdandtesting.mddocumentation for accuracy and consistency.Operations
No user-facing impact; changes are confined to developer documentation and test configuration. No additional operational testing is required.