Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: market data benchmarking outcomes #8399

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

perf: market data benchmarking outcomes #8399

wants to merge 4 commits into from

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Dec 18, 2024 •
edited
Loading

Description

Adds some incremental improvements and cleanup stemming from performance benchmarking done in #8188

Issue (if applicable)

progresses #8188

Risk

High Risk PRs Require 2 approvals

High risk as this affects initial loading of asset data used by the rest of the app.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Check asset list is correct
  • Check portfolio assets are loaded after cache clear
  • General sanity check of app for unforeseen issues

Engineering

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

@woodenfurniture woodenfurniture force-pushed the market-data-benchmarking branch from bfead1c to ce90b1c Compare December 18, 2024 21:49
@woodenfurniture woodenfurniture marked this pull request as ready for review December 18, 2024 21:53
@woodenfurniture woodenfurniture requested a review from a team as a code owner December 18, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
high risk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woodenfurniture