Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: solana native support #8673

Merged
merged 2 commits into from
Jan 28, 2025
Merged

feat: solana native support #8673

merged 2 commits into from
Jan 28, 2025

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 27, 2025 •
edited
Loading

Description

Bumps hdwallet to latest, supporting shapeshift/hdwallet#702

Issue (if applicable)

closes #8242

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low? Assuming right addies are derived and users can sign, there should be not much risk here

Testing

  • Import a native wallet or add Solana accounts to your existing native wallet using account management
  • Ensure addies are correct (i.e account 0 should match Phantom/Ledger's)
  • Ensure you can sign Txs

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/536c6583-6bda-44a3-aa97-29883dc1536d

@gomesalexandre gomesalexandre marked this pull request as ready for review January 27, 2025 23:18
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 27, 2025 23:18
0xApotheosis
0xApotheosis approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derivation is correct and in line with Phantom:

Screenshot 2025-01-28 at 17 07 52 Screenshot 2025-01-28 at 17 08 06 Screenshot 2025-01-28 at 17 08 21

Can happily sign:

Screenshot 2025-01-28 at 17 11 37

@0xApotheosis 0xApotheosis merged commit 755e5dc into develop Jan 28, 2025
3 checks passed
@0xApotheosis 0xApotheosis deleted the feat_hdwallet_native_solana branch January 28, 2025 06:12
@gomesalexandre gomesalexandre mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solana support for native wallet
2 participants
@gomesalexandre @0xApotheosis