Alert tag rewrite #1074
Merged
Alert tag rewrite #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabstejnek
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Have you or could you look into making the alert template tag more like with or the like? ie where you can construct it like {% alert type="danger" %} instead of {% alert "type=danger" %}, just for consistency's sake.
https://github.com/django/django/blob/main/django/template/defaulttags.py#L1509
In that link you will also see there are token parsers provided by django, so we may be able to cut down on some code as well.
rabstejnek
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add args + kwargs functionality to the alert template tag, and use the tag where possible.