-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client Update + BMD Export #1079
Conversation
caseyhans
commented
Aug 14, 2024
- Add an animal bmds export
- Add .json to visual & datapivot endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I recommend renaming the dfs if possible to be a little descriptive to make it easier to maintain the code, otherwise everything is good to go.
I noticed an error in the output when demoing for a user, it looks like if there are multiple dose units, the N, resp, incidence columns are repeated. In this case there are 4 dose groups, 3 dose units, and there are 12 ns, when there should be 4 (I added indentation to show the repetition): {
"endpoint_id": 100008477,
"n": [
5, 5, 5, 5,
5, 5, 5, 5,
5, 5, 5, 5
],
"response": [
4.125, 4.241, 4.362, 5.107,
4.125, 4.241, 4.362, 5.107,
4.125, 4.241, 4.362, 5.107
],
"stdev": [
0.239, 0.259, 0.295, 0.126,
0.239, 0.259, 0.295, 0.126,
0.239, 0.259, 0.295, 0.126
],
"dtype": "C",
"doses": {
"mg/m3": [0, 429.9, 1658.6, 3395.4],
"ppm": [0, 100, 400, 800],
"ppm (analytical)": [0, 99, 382, 782]
},
"incidence": null
} @caseyhans - I can work on this too if you're doing other things, I was the person who wrote the original implementation, and likely this bug, just let me know |
@caseyhans ok, I think I fixed the duplicates in 3af550d. Made a few more edits, let me know when you're happy and you can assign to @munnsmunns and myself for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!