Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Update + BMD Export #1079

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Client Update + BMD Export #1079

merged 14 commits into from
Sep 18, 2024

Conversation

caseyhans
Copy link
Collaborator

  • Add an animal bmds export
  • Add .json to visual & datapivot endpoints

Copy link
Collaborator

@munnsmunns munnsmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I recommend renaming the dfs if possible to be a little descriptive to make it easier to maintain the code, otherwise everything is good to go.

hawc/apps/animal/exports.py Outdated Show resolved Hide resolved
@shapiromatron
Copy link
Owner

shapiromatron commented Aug 28, 2024

I noticed an error in the output when demoing for a user, it looks like if there are multiple dose units, the N, resp, incidence columns are repeated. In this case there are 4 dose groups, 3 dose units, and there are 12 ns, when there should be 4 (I added indentation to show the repetition):

{
    "endpoint_id": 100008477,
    "n": [
        5, 5, 5, 5, 
        5, 5, 5, 5, 
        5, 5, 5, 5
    ],
    "response": [
        4.125, 4.241, 4.362, 5.107, 
        4.125, 4.241, 4.362, 5.107, 
        4.125, 4.241, 4.362, 5.107
    ],
    "stdev": [
        0.239, 0.259, 0.295, 0.126, 
        0.239, 0.259, 0.295, 0.126, 
        0.239, 0.259, 0.295, 0.126
    ],
    "dtype": "C",
    "doses": {
      "mg/m3": [0, 429.9, 1658.6, 3395.4],
      "ppm": [0, 100, 400, 800],
      "ppm (analytical)": [0, 99, 382, 782]
    },
    "incidence": null
  }

@caseyhans - I can work on this too if you're doing other things, I was the person who wrote the original implementation, and likely this bug, just let me know

@munnsmunns munnsmunns removed their assignment Sep 4, 2024
@shapiromatron
Copy link
Owner

@caseyhans ok, I think I fixed the duplicates in 3af550d. Made a few more edits, let me know when you're happy and you can assign to @munnsmunns and myself for review

@shapiromatron shapiromatron changed the title Client Update Client Update + BMD Export Sep 10, 2024
@munnsmunns munnsmunns removed their assignment Sep 16, 2024
Copy link
Owner

@shapiromatron shapiromatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@shapiromatron shapiromatron merged commit b696603 into main Sep 18, 2024
6 checks passed
@shapiromatron shapiromatron deleted the client-updates branch September 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants