-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ruff Rules #1080
Merged
Merged
Update Ruff Rules #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munnsmunns
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, nice job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code base to accept previously ignored ruff rules.
Notes on other ignored rules:
S308: using mark_safe
- we use this a lot in template tags
- HERO uses a custom HTML sanitizer that calls mark_safe, which is then flagged as safe inline
- We could use this approach, or flag all our mark_safes inline
S314: raised when parsing XML input; I believe it'd require a new package to solve (defusedxml)
- 4 cases; could flag inline & remove from ignore list
- 3 cases are from parsing pubmed imports, one other is in a lit migration (0012) that parses HERO/RIS
S603: executing subprocess calls on "untrusted" inputs
- 4 cases; could be flagged as safe inline
- two of these cases are in the assessment_db_dump.py command for getting the db name from settings
- two of these are in the git.py commit model that returns last commit info; runs "git log" and grabs output
RUF012: 825 errors. too many to fix. related to mutable class attribute annotations
RUF015: iteration check; 3 failing cases, could be flagged safe inline