Add version check for firstnode in restore network

src/API.ts

@@ -102,6 +102,12 @@ export function registerRoutes(server: FastifyInstance<Server, IncomingMessage,
         publicKey,
       }
 
+      const networkAccount: AccountDB.AccountCopy | string = getGlobalNetworkAccount(false)
+      if(typeof networkAccount !== 'string' && !NodeList.isValidVersion(networkAccount?.data?.minVersion, networkAccount?.data?.latestVersion, signedFirstNodeInfo.nodeInfo.version)) {
+        Logger.mainLogger.error('Invalid version', signedFirstNodeInfo.nodeInfo.version)
+        reply.send({ success: false, error: 'Invalid version' })
+      }
+
       Data.initSocketClient(firstNode)
 
       // Add first node to NodeList

src/GlobalAccount.ts

@@ -24,7 +24,7 @@ export interface GlobalAccountsHashAndTimestamp {
 export const globalAccountsMap = new Map<string, GlobalAccountsHashAndTimestamp>()
 const appliedConfigChanges = new Set<string>()
 
-export function getGlobalNetworkAccount(hash: boolean): object | string {
+export function getGlobalNetworkAccount(hash: boolean): AccountDB.AccountCopy | string {
   if (hash) {
     return cachedGlobalNetworkAccountHash
   }

src/NodeList.ts

@@ -416,3 +416,31 @@ export function toggleFirstNode(): void {
   foundFirstNode = !foundFirstNode
   Logger.mainLogger.debug('foundFirstNode', foundFirstNode)
 }
+
+export function isEqualOrNewerVersion(minimumVersion: string, testVersion: string): boolean {
+  if (minimumVersion === testVersion) {
+    return true
+  }
+
+  const minVerParts = minimumVersion.split('.')
+  const testVerParts = testVersion.split('.')
+  /* eslint-disable security/detect-object-injection */
+  for (let i = 0; i < testVerParts.length; i++) {
+    const testV = ~~testVerParts[i] // parse int
+    const minV = ~~minVerParts[i] // parse int
+    if (testV > minV) return true
+    if (testV < minV) return false
+  }
+  /* eslint-enable security/detect-object-injection */
+  return false
+}
+
+export function isEqualOrOlderVersion(maximumVersion: string, testVersion: string): boolean {
+  return isEqualOrNewerVersion(testVersion, maximumVersion)
+}
+
+export function isValidVersion(minimumVersion: string, latestVersion: string, testVersion: string): boolean {
+  const equalOrNewer = isEqualOrNewerVersion(minimumVersion, testVersion)
+  const equalOrOlder = isEqualOrOlderVersion(latestVersion, testVersion)
+  return equalOrNewer && equalOrOlder
+}

src/P2P.ts

@@ -37,6 +37,7 @@ export interface FirstNodeInfo {
     externalIp: string
     externalPort: number
     publicKey: string
+    version: string
   }
 }
 export interface FirstNodeResponse {