-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHARD-44: GlobalTx fixes #103
Open
S0naliThakur
wants to merge
4
commits into
itn4
Choose a base branch
from
globalTx-fixes
base: itn4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+283
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Data/Collector.ts
Outdated
@@ -73,6 +73,11 @@ | |||
executionGroupNodes: ConsensusNodeInfo[], | |||
minConfirmations: number = config.RECEIPT_CONFIRMATIONS | |||
): Promise<{ success: boolean; newReceipt?: Receipt.ArchiverReceipt }> => { | |||
// If robustQuery is disabled, do offline verification | |||
if (!config.useRobustQueryForReceipt) { |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
This condition guards a sensitive , but a controls it.
action
Error loading related location
Loading user-provided value
Error loading related location
Loading
S0naliThakur
force-pushed
the
globalTx-fixes
branch
2 times, most recently
from
November 26, 2024 16:39
793f574
to
c131ed4
Compare
S0naliThakur
requested review from
jintukumardas,
abdulazeem-tk4vr and
aniketdivekar
November 26, 2024 16:41
S0naliThakur
force-pushed
the
globalTx-fixes
branch
2 times, most recently
from
December 12, 2024 14:07
f29133e
to
cf6a9e3
Compare
if (nestedCountersInstance) | ||
nestedCountersInstance.countEvent( | ||
'receipt', | ||
'Invalid_receipt_globalModification_valid_signs_count_less_than_votingGroupCount' |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
This condition guards a sensitive , but a controls it.
This condition guards a sensitive action, but a controls it.
This condition guards a sensitive action, but a controls it.
action
Error loading related location
Loading user-provided value
Error loading related location
Loading This condition guards a sensitive action, but a
user-provided value
Error loading related location
Loading This condition guards a sensitive action, but a
user-provided value
Error loading related location
Loading
S0naliThakur
force-pushed
the
globalTx-fixes
branch
from
December 13, 2024 06:28
56d1083
to
832bdec
Compare
…loadReceipt, improved error logs, deprecated setupWorkerProcesses and offloadReceipt.
devendra-shardeum
approved these changes
Dec 13, 2024
aniketdivekar
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear: https://linear.app/shm/issue/SHARD-44/globaltx-validation
Summary: Implement global receipt validation and enhance receipt verification logic
useRobustQueryForReceipt
flagstoreReceipt
method to useverifyArchiverReceipt
directly.verifyGlobalTxreceiptOffline
andverifyReceiptMajority
for better code readability.