-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLUE-209 Profiler for receipt validation on the archiver #61
Conversation
PR Reviewer Guide 🔍
|
`The account verification failed from robustQuery nodes ${receipt.tx.txId} , ${receipt.cycle}, ${receipt.tx.timestamp}` | ||
) | ||
continue | ||
if (config.verifyAccountData) { |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
action
user-provided value
`The receipt validation failed from robustQuery nodes ${receipt.tx.txId} , ${receipt.cycle}, ${receipt.tx.timestamp}` | ||
) | ||
continue | ||
if (config.verifyReceiptData) { |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
action
user-provided value
timestamp | ||
) | ||
receiptsInValidationMap.delete(txId) | ||
if (config.verifyAccountData) { |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
action
user-provided value
nestedCountersInstance.countEvent('receipt', 'Invalid_receipt_verification_failed') | ||
if (profilerInstance) profilerInstance.profileSectionEnd('Validate_receipt') | ||
continue | ||
if (config.verifyReceiptData) { |
Check failure
Code scanning / CodeQL
User-controlled bypass of security check High
action
user-provided value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes looks good to me.
bb69845
to
4dd5f3b
Compare
Its in dev. |
No description provided.