RED-201 Network Generated Transactions #65
Conversation
PR Reviewer Guide 🔍
|
ahmxdiqbal
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| export function addTxs(addTxs: P2P.ServiceQueueTypes.AddNetworkTx[]): boolean { | ||
| try { | ||
| for (const addTx of addTxs) { | ||
| Logger.mainLogger.info(`Adding network tx of type ${addTx.type} and payload ${stringifyReduce(addTx.txData)}`) |
Check warning
Code scanning / CodeQL
Log injection Medium
| for (const removeTx of removeTxs) { | ||
| const index = txList.findIndex((entry) => entry.hash === removeTx.txHash) | ||
| if (index === -1) { | ||
| Logger.mainLogger.error(`TxHash ${removeTx.txHash} does not exist in txList`) |
Check warning
Code scanning / CodeQL
Log injection Medium
write updateNetworkTxsList func create /network-txs-list endpoint fix: improper logic in case txRemove tx is not in txList ServiceQueue: updated sortedInsert() definition and calls ServiceQueue: fix Logger import add verify function for syncing txList add queries for syncing txList from validators add syncTxList func + use it in syncV2 step add ServiceQueue funcs + minor refactor handle case where txList isnt correct post-cycle record parse
afostr
force-pushed
the
serviceQueue-impl
branch
from
f7f0ed2
to
41b5c1f
Compare
PR for archiver changes of the reliable reward txs aka network generated txs project