SHARD-1923: Use cert scores to determine which cycle received from subscribed nodes to save #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logCycle ? StringUtils.safeStringify(receivedCycleTracker[counter][key]['senderNodes']) : '', | ||
| logCycle ? receivedCycleTracker[counter][key] : '' | ||
| logCycle ? StringUtils.safeStringify([...receivedCycleTracker[counter][marker]['certSigners']]) : '', | ||
| logCycle ? receivedCycleTracker[counter][marker] : '' |
Check warning
Code scanning / CodeQL
Log injection
Copilot Autofix AI 14 days ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
urnotsam
reviewed
Mar 7, 2025
urnotsam
reviewed
Mar 7, 2025
mhanson-github
force-pushed
the
SHARD-1923
branch
from
fa61ffb to
e3ab871
Compare
urnotsam
reviewed
Mar 8, 2025
urnotsam
previously approved these changes
Mar 8, 2025
aniketdivekar
previously approved these changes
Mar 10, 2025
aniketdivekar
force-pushed
the
SHARD-1923
branch
from
424f366 to
bb39dd4
Compare
mssabr01
requested changes
Mar 10, 2025
src/Config.ts
Outdated
| @@ -249,6 +250,7 @@ let config: Config = { | |||
| maxRecordsPerRequest: 200, | |||
| multisigKeysSyncFromNetworkInternal: 600, | |||
| minCycleConfirmationsToSave: -1, | |||
| nerfNonFoundationCertScores: false, | |||
There was a problem hiding this comment.
Should this be true? Default config should be what we are looking to run on mainnet
There was a problem hiding this comment.
its currently set to false on server side. these should match. Will get confirmation on what this should be
mssabr01
approved these changes
Mar 10, 2025
urnotsam
approved these changes
Mar 10, 2025
urnotsam
force-pushed
the
SHARD-1923
branch
2 times, most recently
from
9cc544b to
882414c
Compare
aniketdivekar
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.