SHARD-1926: compare afterStateHash in receipt verification #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhanson-github
previously approved these changes
Mar 8, 2025
aniketdivekar
previously approved these changes
Mar 10, 2025
aniketdivekar
force-pushed
the
SHARD-1926
branch
from
677f4ef to
171059a
Compare
urnotsam
force-pushed
the
SHARD-1926
branch
2 times, most recently
from
712dc59 to
a2239e9
Compare
abdulazeem-tk4vr
dismissed stale reviews from aniketdivekar and mhanson-github
via
f1829df
abdulazeem-tk4vr
force-pushed
the
SHARD-1926
branch
2 times, most recently
from
f1829df to
221bc09
Compare
mhanson-github
force-pushed
the
SHARD-1926
branch
from
0ff824d to
e6a9a59
Compare
- Enhanced verifyGlobalTxAccountChange function with detailed documentation - Improved error messages for network account state verification - Added TODO comment for potential optimization in account lookup - Removed unnecessary console.dir and commented-out code - Refined hash comparison and error reporting for global modification transactions
mhanson-github
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary :
The global Tx receipt verification flow on the archiver side now fetches the afterStateHash from the signed receipt and then compares it with the entry from the afterStates array