Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for shardus-types #432

Open
wants to merge 1 commit into
base: mainnet-launch
Choose a base branch
from
Open

Add unit tests for shardus-types #432

wants to merge 1 commit into from
+2,237 −0

Conversation

S0naliThakur
Copy link
Member

No description provided.

BelfordZ
BelfordZ requested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@BelfordZ BelfordZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We doint need to test files that only export types. Or at least for now. Lets hit snooze on these.

@S0naliThakur
Copy link
Member Author

We doint need to test files that only export types. Or at least for now. Lets hit snooze on these.

May be we should remove/mark such instances from the list.
cc: @mhanson-github @aniketdivekar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BelfordZ BelfordZ BelfordZ requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S0naliThakur @BelfordZ