Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-190-lib-archiver-discovery-github-workflow #3

Closed
wants to merge 1 commit into from
Closed

sys-190-lib-archiver-discovery-github-workflow #3

wants to merge 1 commit into from

Conversation

chrypnotoad
Copy link

No description provided.

@linear Linear
Copy link

linear bot commented Jun 10, 2024

SYS-190 lib-archiver-discovery github workflow

@github-actions GitHub Actions
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]

2

🧪 Relevant tests

No

🔒 Security concerns

No

⚡ Key issues to review

Workflow Configuration:
Ensure that the branch conditions in the workflow triggers (push, pull_request) align with the intended branches for CI operations.

Dependency on External Workflow:
The PR uses external workflows (shardeum/github-automation/.github/workflows/node-ci-shared.yml). Verify that these workflows are secure and maintained.

muni-corn
muni-corn suggested changes Jul 9, 2024
View reviewed changes
Copy link

@muni-corn muni-corn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo needs an npm build script or build phase to be skipped

@mhanson-github
Copy link

This got subsumed by caralee's pr.

@mhanson-github mhanson-github deleted the sys-190-lib-archiver-discovery-github-workflow branch September 7, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muni-corn muni-corn muni-corn requested changes

Assignees
No one assigned
Labels
Review effort [1-5]: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrypnotoad @mhanson-github @muni-corn