Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gold-180 - fix: inproper nodejs task scheduling, use mpsc for multi_send #10

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Gold-180 - fix: inproper nodejs task scheduling, use mpsc for multi_send #10

wants to merge 5 commits into from
+212 −63

Commits on Aug 16, 2024

  1. fix: inproper nodejs task scheduling, use mpsc for multi_send 

    The why - In multi send neon binding the function is spawning tokio
threads for every ip:port pair along with O(n) oneshot channel pairs
with nodejs callback function being Atomically reference counted this
bring no benefit whatsoever while impact performance and lost thread
yeilding and lost thread wakers on non-ideal/edge situation.
    @kgmyatthu @mhanson-github
    kgmyatthu authored and mhanson-github committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e18be25 View commit details
    Browse the repository at this point in the history

  2. fix: decrement stats proper

    @kgmyatthu @mhanson-github
    kgmyatthu authored and mhanson-github committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    34b95c1 View commit details
    Browse the repository at this point in the history

  3. refactor: add test support for multiple addresses and ports

    @abdulazeem-tk4vr @mhanson-github
    abdulazeem-tk4vr authored and mhanson-github committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    69e3565 View commit details
    Browse the repository at this point in the history

  4. fix: ts side of error callback now know how to handle err

    @kgmyatthu @mhanson-github
    kgmyatthu authored and mhanson-github committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    385a195 View commit details
    Browse the repository at this point in the history

  5. fix: error array index skipping

    @kgmyatthu @mhanson-github
    kgmyatthu authored and mhanson-github committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b0b7cf0 View commit details
    Browse the repository at this point in the history