Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYS-197 sync up with other changes and add unit tests #5

Merged
merged 2 commits into from
May 27, 2024
Merged

SYS-197 sync up with other changes and add unit tests #5

merged 2 commits into from
May 27, 2024

Conversation

TieDyedSheep
Copy link

@TieDyedSheep TieDyedSheep commented May 22, 2024 •
edited by chrypnotoad
Loading

  • adds a workflow which runs on every PR to call the shared workflow shardeum/github-automation/.github/workflows/node-ci-shared.yml
  • fixed some linting errors since build was failing because all the files to lint were ignored by the ignorePatterns in .eslintrc.json
  • removed types.ts from the ignorePatterns in `.eslintrc.json
  • lint and lint-windows consolidated to just lint which should pass in glob pattern to eslint on all platforms

@linear Linear
Copy link

linear bot commented May 22, 2024

SYS-197 lib-net github workflow

@chrypnotoad chrypnotoad requested a review from a team May 23, 2024 15:09
TieDyedSheep
TieDyedSheep commented May 23, 2024
View reviewed changes
Copy link
Author

@TieDyedSheep TieDyedSheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Chris' changes but I can't hit approve because I created the PR

chrypnotoad
chrypnotoad reviewed May 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
uses: actions/[email protected]
with:
node-version: '${{ vars.NODE_VERSION }}'
cache: 'npm'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try caching the deps here too?

Suggested change
cache: 'npm'
cache: 'npm'
cache-dependency-path: package-lock.json

@chrypnotoad chrypnotoad requested a review from arhamj May 27, 2024 21:18
paulgs9988
paulgs9988 approved these changes May 27, 2024
View reviewed changes
Copy link

@paulgs9988 paulgs9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again for the detailed summary @chrypnotoad !

@chrypnotoad chrypnotoad merged commit c99a4a7 into dev May 27, 2024
4 checks passed
@TieDyedSheep TieDyedSheep deleted the SYS-197-add-ci-workflow branch July 8, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrypnotoad chrypnotoad chrypnotoad approved these changes

@paulgs9988 paulgs9988 paulgs9988 approved these changes

@arhamj arhamj Awaiting requested review from arhamj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TieDyedSheep @chrypnotoad @paulgs9988