SHARD-916 Workflow addition to build and push docker image #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhamj
changed the title
aniketdivekar
previously approved these changes
Oct 23, 2024
aniketdivekar
previously approved these changes
Oct 23, 2024
chrypnotoad
reviewed
Oct 24, 2024
.github/workflows/docker.yml
Outdated
Comment on lines
8
to
11
| tag: | ||
| description: 'Tag for the Docker image' | ||
| required: false | ||
| default: 'latest' # Default tag if none is provided |
There was a problem hiding this comment.
this input isn't being used when the tag is set
chrypnotoad
changed the title
chrypnotoad
approved these changes
Oct 25, 2024
chrypnotoad
added a commit
that referenced
this pull request
Oct 25, 2024
…)" This reverts commit 68415c2.
chrypnotoad
added a commit
that referenced
this pull request
Oct 25, 2024
…)" This reverts commit 68415c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/shm/issue/SHARD-916