Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Support Ruby 3.0 #217

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Drop Support Ruby 3.0 #217

wants to merge 10 commits into from

Commits on Jun 15, 2024

  1. Attempt to create Github Actions based on CircleCI jobs 

      + Rspec tasks (for Ruby 2.7.x, 3.0.x, 3.1.x, 3.2.x)
  + Rubocop task (with Ruby 2.7.x)
  + Yard & Github pages tasks (with Ruby 2.7.x)

  + Update rspec version constraint in discordrb.gemspec (from ~> 3.11.0 to ~> 3.12.0)
  + Update redcarpet version constraint in discordrb.gemspec (from ~> 3.5.0 to ~> 3.6.0)
    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    8f9f4ad View commit details
    Browse the repository at this point in the history

  2. Edit README.md

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    9bed24a View commit details
    Browse the repository at this point in the history

  3. Reversal of a previous modification concerning Webhook#update_webhook 

      Finally, after doing my tests on the latest version of Rspec, and looking at the code, I realize that the modification was not necessary, and PixeLInc was right in his PR shardlab#199
    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    75c157f View commit details
    Browse the repository at this point in the history

  4. Remove CircleCI configuration which is not required anymore

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    b3433ab View commit details
    Browse the repository at this point in the history

  5. Fix a bug in update_channel_data 

      Contrary to what the documentation indicated, it was not possible to provide an Array<Overwrite> to Channel#permission_overwrites=

  It was necessary to provide the Hash similar to what the method Channel#permission_overwrites returns

  + Added an example file to test the overwrites (I used it as a debug)
  + Modification of a test in spec/data/channel_spec.rb following this correction
    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    6a647ab View commit details
    Browse the repository at this point in the history

  6. Make sure to run Github Actions only on main or main's pull_request

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    fd9ef3f View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Fix typo and newlines

Co-authored-by: Adrien Smith <[email protected]>
    @Dakurei @PanisSupraOmnia
    Dakurei and PanisSupraOmnia committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    65ac49f View commit details
    Browse the repository at this point in the history

  8. Apply modifications from version bump 3.5.0

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    a6d9605 View commit details
    Browse the repository at this point in the history

  9. Add Ruby 3.3 to Rspec matrix

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    8cd5227 View commit details
    Browse the repository at this point in the history

  10. Ruby 3.0 EOL and Dependency Chores

    @Dakurei
    Dakurei committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    7f4936e View commit details
    Browse the repository at this point in the history