Fix InteractionCreateEvent type matching #251
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some bugs where matching Interactions based on type via a symbol or string wasn't working. There was a typo in the matcher block, and as far as I can call the comparison wasn't working either. Specs have been added to cover all formats described as supported in the documentation for matching Interaction types (Integer, String, and Symbol).
Example broken code before this fix:
This would result in
NameError: uninitialized constant Discordrb::Interactions::TYPES
Added
InteractionCreateEvent
Changed
:type
attribute inInteractionCreateEventHandler
Deprecated
Removed
Fixed
NameError: uninitialized constant Discordrb::Interactions::TYPES
inInteractionCreateEventHandler
when matching on:type
InteractionCreateEventHandler
:type
attribute