Fix "Cannot read properties of null (reading 'callback')" error occured in Doc.prototype._handleSubscribe #613
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please identify the root cause of this? If you're on the latest version of ShareDB you might have these warnings in your logs: #607 |
|
Also see: #605 |
|
I don't think this is the right fix for this; we should never reach this state. |
|
Thanks for your response. I will check the code and find out why it happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a "Cannot read properties of null (reading 'callback')" error in our logging system when using this library in our project. The error occured in method: Doc.prototype._handleSubscribe. When this method called variable
requestwould be null.Add two checkings to fix it.