Merge pull request #515 from sharetribe/fix-in-page-anchor-for-Listin…

…gPageVariant ListingPageVariant: the #author anchor was pointing to ListingPage.
sharetribe · Dec 9, 2024 · 94a4fa4 · 94a4fa4
2 parents 1ddd04e + c149696
commit 94a4fa4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,8 @@ way to update this template, but currently, we follow a pattern:
 
 ## Upcoming version 2024-XX-XX
 
+- [fix] ListingPageVariant: the #author anchor was not pointing to ListingPageVariant.
+  [#515](https://github.com/sharetribe/web-template/pull/515)
 - [fix] target element didn't seem to work well with scroll-margin.
   [#513](https://github.com/sharetribe/web-template/pull/513)
 - [change] Require account type when creating a Stripe account

diff --git a/src/containers/ListingPage/ListingPageCarousel.js b/src/containers/ListingPage/ListingPageCarousel.js
@@ -127,6 +127,7 @@ export const ListingPageComponent = props => {
 
   const listingConfig = config.listing;
   const listingId = new UUID(rawParams.id);
+  const isVariant = rawParams.variant != null;
   const isPendingApprovalVariant = rawParams.variant === LISTING_PAGE_PENDING_APPROVAL_VARIANT;
   const isDraftVariant = rawParams.variant === LISTING_PAGE_DRAFT_VARIANT;
   const currentListing =
@@ -384,7 +385,7 @@ export const ListingPageComponent = props => {
               authorLink={
                 <NamedLink
                   className={css.authorNameLink}
-                  name="ListingPage"
+                  name={isVariant ? 'ListingPageVariant' : 'ListingPage'}
                   params={params}
                   to={{ hash: '#author' }}
                 >
@@ -493,7 +494,7 @@ const EnhancedListingPage = props => {
   const location = useLocation();
 
   const showListingError = props.showListingError;
-  const isVariant = props.params?.variant?.length > 0;
+  const isVariant = props.params?.variant != null;
   const currentUser = props.currentUser;
   if (isForbiddenError(showListingError) && !isVariant && !currentUser) {
     // This can happen if private marketplace mode is active

diff --git a/src/containers/ListingPage/ListingPageCoverPhoto.js b/src/containers/ListingPage/ListingPageCoverPhoto.js
@@ -127,6 +127,7 @@ export const ListingPageComponent = props => {
 
   const listingConfig = config.listing;
   const listingId = new UUID(rawParams.id);
+  const isVariant = rawParams.variant != null;
   const isPendingApprovalVariant = rawParams.variant === LISTING_PAGE_PENDING_APPROVAL_VARIANT;
   const isDraftVariant = rawParams.variant === LISTING_PAGE_DRAFT_VARIANT;
   const currentListing =
@@ -381,7 +382,7 @@ export const ListingPageComponent = props => {
               authorLink={
                 <NamedLink
                   className={css.authorNameLink}
-                  name="ListingPage"
+                  name={isVariant ? 'ListingPageVariant' : 'ListingPage'}
                   params={params}
                   to={{ hash: '#author' }}
                 >
@@ -490,7 +491,7 @@ const EnhancedListingPage = props => {
   const location = useLocation();
 
   const showListingError = props.showListingError;
-  const isVariant = props.params?.variant?.length > 0;
+  const isVariant = props.params?.variant != null;
   const currentUser = props.currentUser;
   if (isForbiddenError(showListingError) && !isVariant && !currentUser) {
     // This can happen if private marketplace mode is active