-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seats: availability management, booking flow, search filter #502
Open
Gnito
wants to merge
40
commits into
main
Choose a base branch
from
seats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
seats
branch
3 times, most recently
from
November 13, 2024 19:27
53948b8
to
12b4c06
Compare
Gnito
force-pushed
the
seats
branch
2 times, most recently
from
November 14, 2024 16:33
e6a3d5a
to
0c4fcec
Compare
Gnito
changed the title
Seats: work-in-progress
Seats: work-in-progress (availability management)
Nov 28, 2024
Gnito
changed the title
Seats: work-in-progress (availability management)
Seats: (wip) availability management
Dec 4, 2024
Gnito
changed the title
Seats: (wip) availability management
Seats: availability management
Dec 5, 2024
(when not dealing with multiple seats)
- initialValues > initialPlanValues - handleSubmit > handlePlanSubmit)
…ize events too early
Seats: booking with seats
Gnito
changed the title
Seats: availability management
Seats: availability management, booking flow
Dec 20, 2024
Seats: filter listings with seats
Gnito
changed the title
Seats: availability management, booking flow
Seats: availability management, booking flow, search filter
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to use multiple seats.
It also changes the UI for weekly calendar on EditListingAvailabilityManagement.
Note: we won't merge this before holiday season is over.
Availability management
The design of the Availability management tab on EditListingWizard is going to change a bit:
Default schedule ("oneSeat"):
Default schedule ("multipleSeats"):
Weekly calendar has a bigger change, we moved towards a single flow of availability slots. I.e. AvailabilityExceptions are shown in the location where they belong to, when compared to plan (default schedule).
Weekly calendar ("oneSeat"):
Weekly calendar ("multipleSeats"):
Booking with seats
If seats are enabled via assets, users can input a number of seats they want to book in transaction processes using the default-booking process.
This introduces major changes to:
In addition, smaller changes are introduced to the InboxPage, CheckoutPage and how line items are calculated server side.
If the seatsEnabled parameter evaluates to true, line-item calculations will default to 1 seat (even if no seat value is passed). seatsEnabled evaluates to true if:
const seatsEnabled = [AVAILABILITY_MULTIPLE_SEATS].includes(listingTypeConfig?.availabilityType);
Seats filter
This PR adds new components. There is a new FieldNumberInput component, as well as a new SeatsFilter component that uses FieldNumberInput. The SeatsFilter component has been implemented on both search pages:
This PR also prepares the codebase to use a hosted configuration for seats filtering, once the feature is released in Console.
Translations
New translation keys
Note: FieldSeatsInput: min = 0, max is 9007199254740991 aka Number.MAX_SAFE_INTEGER
Deleted translation keys