Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with seats handling in email template #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shareoc
Copy link
Contributor

@shareoc shareoc commented Dec 17, 2024

Line-item calculation with seats was giving wrong results, this PR fixes the issue.

New translation keys

"BookingAcceptedRequest.PriceBreakdownDailyWithSeats": "{currency} {amount, number, ::.00} × {multiplier, number} {multiplier, plural, one {day} other {days}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingAcceptedRequest.PriceBreakdownHourlyWithSeats": "{currency} {amount, number, ::.00} × {multiplier, number} {multiplier, plural, one {hour} other {hours}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingAcceptedRequest.PriceBreakdownNightlyWithSeats": "{currency} {amount, number, ::.00} × {multiplier, number} {multiplier, plural, one {night} other {nights}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingMoneyPaid.PriceBreakdownDailyWithSeats": "{currency} {amount, number, ::.00} × {multiplier, number} {multiplier, plural, one {day} other {days}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingMoneyPaid.PriceBreakdownHourlyWithSeats": "{currency} {amount, number, ::.00} × {multiplier, number} {multiplier, plural, one {hour} other {hours}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingMoneyPaid.PriceBreakdownNightlyWithSeats": "{amount, number, ::.00} {currency} × {multiplier, number} {multiplier, plural, one {night} other {nights}} x {seats, number} {seats, plural, one {seat} other {seats}}}",
"BookingNewRequest.PriceForDaysQuantityWithSeats": "{currency} {amount, number, ::.00} × {units, number} {units, plural, one {day} other {days}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingNewRequest.PriceForHoursQuantityWithSeats": "{currency} {amount, number, ::.00} × {units, number} {units, plural, one {hour} other {hours}} x {seats, number} {seats, plural, one {seat} other {seats}}",
"BookingNewRequest.PriceForNightsQuantityWithSeats": "{currency} {amount, number, ::.00} × {units, number} {units, plural, one {night} other {nights}} x {seats, number} {seats, plural, one {seat} other {seats}}"

Deleted translation keys

"BookingAcceptedRequest.SeatsQuantity": "Seats × {multiplier, number}",
"BookingMoneyPaid.SeatsQuantity": "Seats × {multiplier, number}",
"BookingNewRequest.SeatsQuantity": "Seats × {seats, number}",

@shareoc shareoc force-pushed the seats-email-templates branch from 49ba42c to 96ec8df Compare December 17, 2024 08:33
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Add translation changes to the description (aka how customizers need to change their email texts on Console).

Let's not merge this before other seats PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants