Update bat's tab expansion preprocessor to use bat's ANSI escape sequence iterator. #2998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates
bat
's tab expansion preprocessing function to usebat
'svscreen::EscapeSequenceOffsetsIterator
instead ofconsole::AnsiCodeIterator
.Benchmarks
When running against a file with no tabs, there are no observable differences:
And when running against a file1 with 34443 tab characters, the difference is negligible:
However, it did trim a little over 16 KiB off the file size:
Footnotes
Command to create the file:
file fd --glob '*.rs' --exec-batch sh -c 'cat "$@" > lots-of.rs' {} && sed -i "s/ /\t/g" lots-of.rs
↩