Skip to content

ENH: Allows to add rooms by specifying a string #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quazgar
Copy link

@quazgar quazgar commented Sep 5, 2018

There's also a new keyword arg for MatrixBotAPI: exclusive_rooms=True tells only the specified rooms should be used, all others will be left.

@mrdumpty
Copy link

Look at my PR, its logic is slightly better. If rooms specified, bot will be exclusive anyway. If not specified, bot will be listening on all of its rooms. Accept invites is the separated option.

@shawnanastasio
Copy link
Owner

Hi @quazgar, thanks for the PR (and sorry for the late response)!

I think the ability to specify rooms by ID string is a useful feature, and your implementation looks good to me.

I'm not sure about the usefulness of the exclusive_rooms functionality you've added, though. Could you maybe explain the rationale for adding it? There's some discussion in PR #18, but it seems that its usefulness is limited, since users can already restrict which rooms the bot is active in with the rooms parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants