workaround ghc-9.10.1/deepseq ambiguity #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayne-fletcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) ghc-9.8.3 build compiler ships with deepseq 15.1.0 which breaks building ghc-9.10.1 source (showing the symptoms of digital-asset#563 see digital-asset#563 (comment)). the fix is already on ghc-9.12 and HEAD. the fix here is to patch ghc-lib-parser flavor ghc-9.10.1 and re-release (ghc-lib-9.10.1.20241103). i updated the happy bounds manually to
happy:happy == 1.20.* || == 2.0.2 || >= 2.1.2 && < 2.2since there's alread a diff in flight for that in digital-asset#567.(2) it looks like flavor ghc-9.8.3 was released from the ghc-9.8 branch, not the ghc-9.8.3 branch (my fault i guess) so that's fixed here as well. i've pushed a new release for that (ghc-lib-9.8.3.20241103) flavor and manually adjusted the happy bounds for that too
happy:happy == 1.20.* || == 2.0.2 || >= 2.1.2 && < 2.2.