Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add exponential backoff to archive download #23

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

Lucassifoni
Copy link
Collaborator

@Lucassifoni Lucassifoni commented Jan 10, 2025

I'm stopping work in my fork now that I have a better view of your project, it will be more practical.
Here is ongoing work on incremental backoff on fetch_archive. I pulled the actual call to a fetch implementation to the outside so it can be more easily tested.

I'd like to finish rewriting all the Logger.debug calls to prefix them with "[Nodelix]" as I find that more elegant / easier to grasp in an application, what do you think ?

Closes #20.

sheerlox
sheerlox previously approved these changes Jan 10, 2025
lib/nodelix/version_manager.ex Outdated Show resolved Hide resolved
@sheerlox sheerlox changed the title Exponential backoff (default to 3 attempts) feat: add exponential backoff to archive download Jan 10, 2025
@sheerlox sheerlox enabled auto-merge (squash) January 10, 2025 15:01
@sheerlox
Copy link
Owner

I'd like to finish rewriting all the Logger.debug calls to prefix them with "[Nodelix]" as I find that more elegant / easier to grasp in an application, what do you think ?

works for me 👍

@sheerlox sheerlox disabled auto-merge January 10, 2025 15:06
@sheerlox sheerlox merged commit 07e592b into dev Jan 10, 2025
7 checks passed
@sheerlox sheerlox deleted the exponential_backoff branch January 10, 2025 15:06
sheerlox pushed a commit that referenced this pull request Jan 10, 2025
## [1.0.0-alpha.15](v1.0.0-alpha.14...v1.0.0-alpha.15) (2025-01-10)

### ✨ Features

* add exponential backoff to archive download ([#23](#23)) ([07e592b](07e592b))

### ⚙️ Continuous Integrations

* **renovate:** keep dev runtime version up-to-date ([a246761](a246761))

### ♻️ Chores

* **action:** update actions/cache action to v4 ([#16](#16)) [skip ci] ([f827bef](f827bef))
* **deps:** lock file maintenance ([7002da2](7002da2))
* **deps:** lock file maintenance ([#22](#22)) [skip ci] ([786fed8](786fed8))
* **deps:** update node.js to v22.13.0 ([#19](#19)) [skip ci] ([3af86b6](3af86b6))
@sheerlox
Copy link
Owner

🎉 This PR is included in version 1.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js servers being down fails the CI workflows
2 participants