-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying qemu-cgc patch directly to qemu #5
base: master
Are you sure you want to change the base?
Conversation
It seems that 90% of version.patch is just removing files, which makes it unreasonably huge. Can you refactor this so those removals are done explicitly in the setup script, or maybe a removals.sh in the patches dir? |
Reworked on the same and that should do it.
|
version.patch is still a million lines long, probably because it includes the addition of the entire dtc repo. do we actually need that? |
I did not notice the dtc repo and it ain't required. I'll remove that |
Removed the unnecessary additions |
Now it includes all of pixman, which is 70% of the diff, can that go away? |
When that was ignored, make failed which is why that is still there. |
That seems extremely bad - we don't need a graphics library for emulating CGC binaries. Can you investigate why this is the case? |
Well, I was wrong on that part. It does work without pixman, removed it and would be pushing the same soon. There were some other issues which actually lead to the above-mentioned pixman issues about which I came to know right now as I investigated. |
Removed the patches that were applied by cloning
qemu-cgc
from Mechaphish. Instead, a new patch file,version.patch
is being applied to the qemu version that is being cloned while buildingshellphish-qemu
.