[MINOR] Block number param additional test (hyperledger#5918)

* add test for hex vs decimal block parameter Signed-off-by: Sally MacFarlane <[email protected]> * typo Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]>
shemnon · Sep 21, 2023 · 277424d · 277424d
1 parent db8bd9d
commit 277424d
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetBlockByNumberTest.java b/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetBlockByNumberTest.java
@@ -82,9 +82,9 @@ public void setUp() {
       blockchain.appendBlock(block, receipts);
     }
 
-    BlockHeader lastestHeader = blockchain.getChainHeadBlock().getHeader();
+    BlockHeader latestHeader = blockchain.getChainHeadBlock().getHeader();
     when(worldStateArchive.isWorldStateAvailable(
-            lastestHeader.getStateRoot(), lastestHeader.getHash()))
+            latestHeader.getStateRoot(), latestHeader.getHash()))
         .thenReturn(Boolean.TRUE);
 
     blockchainQueries = spy(new BlockchainQueries(blockchain, worldStateArchive));

diff --git a/...ava/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/BlockParameterTest.java b/...ava/org/hyperledger/besu/ethereum/api/jsonrpc/internal/parameters/BlockParameterTest.java
@@ -114,6 +114,34 @@ public void longShouldReturnLongNumberValue() {
     assertThat(blockParameter.isSafe()).isFalse();
   }
 
+  @Test
+  public void numberStringShouldReturnLongNumberValue() {
+    final BlockParameter blockParameter = new BlockParameter("55");
+    assertThat(blockParameter.getNumber()).isPresent();
+    assertThat(blockParameter.getNumber().get()).isEqualTo(55L);
+
+    assertThat(blockParameter.isNumeric()).isTrue();
+    assertThat(blockParameter.isEarliest()).isFalse();
+    assertThat(blockParameter.isFinalized()).isFalse();
+    assertThat(blockParameter.isLatest()).isFalse();
+    assertThat(blockParameter.isPending()).isFalse();
+    assertThat(blockParameter.isSafe()).isFalse();
+  }
+
+  @Test
+  public void hexShouldReturnLongNumberValue() {
+    final BlockParameter blockParameter = new BlockParameter("0x55");
+    assertThat(blockParameter.getNumber()).isPresent();
+    assertThat(blockParameter.getNumber().get()).isEqualTo(85L);
+
+    assertThat(blockParameter.isNumeric()).isTrue();
+    assertThat(blockParameter.isEarliest()).isFalse();
+    assertThat(blockParameter.isFinalized()).isFalse();
+    assertThat(blockParameter.isLatest()).isFalse();
+    assertThat(blockParameter.isPending()).isFalse();
+    assertThat(blockParameter.isSafe()).isFalse();
+  }
+
   @Test
   public void upperCaseStringShouldBeHandled() {
     final BlockParameter blockParameter = new BlockParameter("LATEST");