review changes

Signed-off-by: Danno Ferrin <[email protected]>
shemnon · Oct 4, 2023 · 5b3f18a · 5b3f18a
1 parent 70ed6a0
commit 5b3f18a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/evm/src/main/java/org/hyperledger/besu/evm/fluent/SimpleAccount.java b/evm/src/main/java/org/hyperledger/besu/evm/fluent/SimpleAccount.java
@@ -195,7 +195,7 @@ public void becomeImmutable() {
    * @return true if a parent account was updated, false if not (this indicates the account should
    *     be inserted into the parent contact).
    */
-  public boolean commit() {
+  public boolean updateParent() {
     if (parent instanceof SimpleAccount simpleAccount) {
       simpleAccount.balance = balance;
       simpleAccount.nonce = nonce;

diff --git a/evm/src/main/java/org/hyperledger/besu/evm/fluent/SimpleWorld.java b/evm/src/main/java/org/hyperledger/besu/evm/fluent/SimpleWorld.java
@@ -122,8 +122,8 @@ public void revert() {
   public void commit() {
     accounts.forEach(
         (address, account) -> {
-          if (!account.commit()) {
-            accounts.put(address, account);
+          if (!account.updateParent()) {
+            parent.accounts.put(address, account);
           }
         });
   }

diff --git a/evm/src/main/java/org/hyperledger/besu/evm/operation/SelfDestructOperation.java b/evm/src/main/java/org/hyperledger/besu/evm/operation/SelfDestructOperation.java
@@ -60,8 +60,8 @@ public OperationResult execute(final MessageFrame frame, final EVM evm) {
     final boolean beneficiaryIsWarm =
         frame.warmUpAddress(beneficiaryAddress) || gasCalculator().isPrecompile(beneficiaryAddress);
 
-    final Address originatorAddresss = frame.getRecipientAddress();
-    final MutableAccount originatorAccount = frame.getWorldUpdater().getAccount(originatorAddresss);
+    final Address originatorAddress = frame.getRecipientAddress();
+    final MutableAccount originatorAccount = frame.getWorldUpdater().getAccount(originatorAddress);
     final Wei originatorBalance = originatorAccount.getBalance();
 
     final long cost =