tests for adding optional v

Signed-off-by: Danno Ferrin <[email protected]>
shemnon · Nov 6, 2023 · a74742e · a74742e
1 parent 50c2e98
commit a74742e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...g/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java b/...g/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/EthGetTransactionByHashTest.java
@@ -182,7 +182,7 @@ void validateResultSpec() {
     assertThat(result.getTo()).isNotNull();
     assertThat(result.getValue()).isNotNull();
     assertThat(result.getYParity()).isNotNull();
-    assertThat(result.getV()).isNull();
+    assertThat(result.getV()).isNotNull();
     assertThat(result.getR()).isNotNull();
     assertThat(result.getS()).isNotNull();
   }

diff --git a/...org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json b/...org/hyperledger/besu/ethereum/api/jsonrpc/eth/eth_getBlockByNumber_complete_shanghai.json
@@ -58,6 +58,7 @@
           "type": "0x2",
           "value": "0x0",
           "yParity": "0x0",
+          "v" : "0x0",
           "r": "0x8abbfbd4c5f2a13a8d5ed394ac50bac7d678f83a23f645818492f76e8ee17ab3",
           "s": "0x7bd38c6929235f775d68b45bd7dea7981264f9a265b6bea97b070e15be88389c"
         }