Copy also computed fields, when doing a Transaction detached copy (hy…

…perledger#6329) Signed-off-by: Fabio Di Fabio <[email protected]>
shemnon · Jan 10, 2024 · d636e7f · d636e7f
1 parent 331833b
commit d636e7f
Showing 1 changed file with 27 additions and 18 deletions.
diff --git a/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java b/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
@@ -1007,24 +1007,33 @@ public Transaction detachedCopy() {
             withCommitments ->
                 blobsWithCommitmentsDetachedCopy(withCommitments, detachedVersionedHashes.get()));
 
-    return new Transaction(
-        true,
-        transactionType,
-        nonce,
-        gasPrice,
-        maxPriorityFeePerGas,
-        maxFeePerGas,
-        maxFeePerBlobGas,
-        gasLimit,
-        detachedTo,
-        value,
-        signature,
-        payload.copy(),
-        detachedAccessList,
-        sender,
-        chainId,
-        detachedVersionedHashes,
-        detachedBlobsWithCommitments);
+    final var copiedTx =
+        new Transaction(
+            true,
+            transactionType,
+            nonce,
+            gasPrice,
+            maxPriorityFeePerGas,
+            maxFeePerGas,
+            maxFeePerBlobGas,
+            gasLimit,
+            detachedTo,
+            value,
+            signature,
+            payload.copy(),
+            detachedAccessList,
+            sender,
+            chainId,
+            detachedVersionedHashes,
+            detachedBlobsWithCommitments);
+
+    // copy also the computed fields, to avoid to recompute them
+    copiedTx.sender = this.sender;
+    copiedTx.hash = this.hash;
+    copiedTx.hashNoSignature = this.hashNoSignature;
+    copiedTx.size = this.size;
+
+    return copiedTx;
   }
 
   private AccessListEntry accessListDetachedCopy(final AccessListEntry accessListEntry) {