V2.13.0 rc0

.github/workflows/codeql-analysis.yml

@@ -33,7 +33,7 @@ jobs:
       uses: actions/checkout@v3
     - uses: actions/[email protected]
       with:
-        go-version: '1.21.10'
+        go-version: '1.23.0'
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2

.github/workflows/lint.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
         with:
-          go-version: 1.21
+          go-version: 1.23
       - uses: technote-space/[email protected]
         with:
           PATTERNS: |

.github/workflows/sims.yml

@@ -11,7 +11,7 @@ jobs:
       - uses: rokroskar/workflow-run-cleanup-action@master
         env:
           GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-    if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/main'"
+    if: ${{ !startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/main' }}
 
   build:
     runs-on: ubuntu-latest
@@ -28,7 +28,7 @@ jobs:
 
   test-sim-nondeterminism:
     runs-on: ubuntu-latest
-    needs: Build
+    needs: build
     steps:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
@@ -44,15 +44,15 @@ jobs:
         with:
           path: ~/go/bin
           key: ${{ runner.os }}-go-runsim-binary
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
       - name: test nondeterminism
         run: |
           make test-sim-nondeterminism
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
 
   test-sim-import-export:
     runs-on: ubuntu-latest
-    needs: Build
+    needs: build
     steps:
       - uses: actions/[email protected]
         with:
@@ -68,15 +68,15 @@ jobs:
         with:
           path: ~/go/bin
           key: ${{ runner.os }}-go-runsim-binary
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
       - name: test-sim-import-export
         run: |
           make test-sim-import-export
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
 
   test-sim-after-import:
     runs-on: ubuntu-latest
-    needs: Build
+    needs: build
     steps:
       - uses: actions/[email protected]
         with:
@@ -92,15 +92,15 @@ jobs:
         with:
           path: ~/go/bin
           key: ${{ runner.os }}-go-runsim-binary
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
       - name: test after import
         run: |
           make test-sim-after-import
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
 
   test-sim-multi-seed-short:
     runs-on: ubuntu-latest
-    needs: Build
+    needs: build
     steps:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
@@ -116,8 +116,8 @@ jobs:
         with:
           path: ~/go/bin
           key: ${{ runner.os }}-go-runsim-binary
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}
       - name: test-sim-multi-seed-short
         run: |
           make test-sim-multi-seed-short
-        if: "env.GIT_DIFF != ''"
+        if: ${{ env.GIT_DIFF != '' }}

.github/workflows/test.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   cleanup-runs:
-    if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/main'"
+    if: ${{ !startsWith(github.ref , 'refs/tags/') && github.ref != 'refs/heads/main' }}
     runs-on: ubuntu-latest
     steps:
       - uses: rokroskar/workflow-run-cleanup-action@master
@@ -19,7 +19,7 @@ jobs:
     steps:
       - uses: actions/[email protected]
         with:
-          go-version: 1.21
+          go-version: 1.23
       - uses: actions/checkout@v3
       - uses: technote-space/[email protected]
         with:
@@ -53,6 +53,7 @@ jobs:
       - uses: codecov/[email protected]
         with:
           file: ./coverage.txt # optional
+          token: 6556fc17-6f3d-40be-b947-0bba9a9fe92f
           fail_ci_if_error: true
 
   test-e2e:
@@ -61,7 +62,7 @@ jobs:
     steps:
       - uses: actions/[email protected]
         with:
-          go-version: 1.19
+          go-version: 1.23
       - uses: actions/checkout@v3
       - uses: technote-space/[email protected]
         with:
@@ -71,6 +72,8 @@ jobs:
             go.sum
       - name: Build Docker Image
         run: make docker-build-debug
+      - name: Build Hermes Image
+        run: make docker-build-hermes
       - name: Test E2E
         run: make test-e2e
 
@@ -81,7 +84,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/[email protected]
         with:
-          go-version: 1.19
+          go-version: 1.23
       - uses: technote-space/[email protected]
         with:
           PATTERNS: |

Makefile

@@ -162,7 +162,7 @@ docker-build-debug:
 
 # in CI.
 docker-build-hermes:
-	@cd tests/e2e/docker; docker build -t cosmos/hermes-e2e:latest -f hermes.Dockerfile .
+	@cd tests/e2e/docker; docker build -t cosmos/hermes-e2e:1.0.0 -f hermes.Dockerfile .
 
 
 image: Dockerfile Dockerfile.update
@@ -192,14 +192,13 @@ localnet-stop:
 	docker-compose down
 
 start-localnet-ci:
-	./build/shentud init liveness --chain-id liveness --home ~/.shentud-liveness
-	./build/shentud config chain-id liveness --home ~/.shentud-liveness
-	./build/shentud config keyring-backend test --home ~/.shentud-liveness
-	./build/shentud keys add val --home ~/.shentud-liveness
-	./build/shentud add-genesis-account val 10000000000000000000000000uctk --home ~/.shentud-liveness --keyring-backend test
-	./build/shentud gentx val 1000000000uctk --home ~/.shentud-liveness --chain-id liveness
-	./build/shentud collect-gentxs --home ~/.shentud-liveness
-	sed -i'' 's/minimum-gas-prices = ""/minimum-gas-prices = "0uatom"/' ~/.shentud-liveness/config/app.toml
+	./build/shentud init liveness -o --chain-id liveness --home ~/.shentud-liveness
+	./build/shentud config set client keyring-backend test --home ~/.shentud-liveness
+	./build/shentud keys add val --keyring-backend test --home ~/.shentud-liveness
+	./build/shentud add-genesis-account val 10000000000000000000stake --home ~/.shentud-liveness --keyring-backend test
+	./build/shentud genesis gentx val 1000000000stake --home ~/.shentud-liveness --chain-id liveness --keyring-backend test
+	./build/shentud genesis collect-gentxs --home ~/.shentud-liveness
+	sed -i 's/minimum-gas-prices = ".*"/minimum-gas-prices = "0stake"/' ~/.shentud-liveness/config/app.toml
 	./build/shentud start --home ~/.shentud-liveness --x-crisis-skip-assert-invariants
 
 .PHONY: start-localnet-ci

app/app.go

@@ -6,6 +6,8 @@ import (
 	"io"
 	"os"
 
+	"github.com/spf13/cast"
+
 	"cosmossdk.io/client/v2/autocli"
 	"cosmossdk.io/core/appmodule"
 	"cosmossdk.io/log"
@@ -22,21 +24,19 @@ import (
 	abci "github.com/cometbft/cometbft/abci/types"
 	tmjson "github.com/cometbft/cometbft/libs/json"
 	tmos "github.com/cometbft/cometbft/libs/os"
-	"github.com/spf13/cast"
 
 	dbm "github.com/cosmos/cosmos-db"
-	"github.com/cosmos/cosmos-sdk/client/flags"
-	"github.com/cosmos/cosmos-sdk/codec/address"
-	"github.com/cosmos/cosmos-sdk/runtime"
-	"github.com/cosmos/cosmos-sdk/server"
-
 	"github.com/cosmos/cosmos-sdk/baseapp"
 	"github.com/cosmos/cosmos-sdk/client"
+	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/client/grpc/cmtservice"
 	nodeservice "github.com/cosmos/cosmos-sdk/client/grpc/node"
 	"github.com/cosmos/cosmos-sdk/codec"
+	"github.com/cosmos/cosmos-sdk/codec/address"
 	"github.com/cosmos/cosmos-sdk/codec/types"
+	"github.com/cosmos/cosmos-sdk/runtime"
 	runtimeservices "github.com/cosmos/cosmos-sdk/runtime/services"
+	"github.com/cosmos/cosmos-sdk/server"
 	"github.com/cosmos/cosmos-sdk/server/api"
 	"github.com/cosmos/cosmos-sdk/server/config"
 	servertypes "github.com/cosmos/cosmos-sdk/server/types"
@@ -82,6 +82,7 @@ import (
 	"github.com/cosmos/cosmos-sdk/x/staking"
 	stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
 	stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
+
 	"github.com/cosmos/ibc-go/modules/capability"
 	capabilitykeeper "github.com/cosmos/ibc-go/modules/capability/keeper"
 	capabilitytypes "github.com/cosmos/ibc-go/modules/capability/types"
@@ -101,6 +102,7 @@ import (
 	porttypes "github.com/cosmos/ibc-go/v8/modules/core/05-port/types"
 	ibcexported "github.com/cosmos/ibc-go/v8/modules/core/exported"
 	ibckeeper "github.com/cosmos/ibc-go/v8/modules/core/keeper"
+	ibctm "github.com/cosmos/ibc-go/v8/modules/light-clients/07-tendermint"
 
 	appparams "github.com/shentufoundation/shentu/v2/app/params"
 	"github.com/shentufoundation/shentu/v2/x/auth"
@@ -509,6 +511,7 @@ func NewShentuApp(
 		oracle.NewAppModule(app.OracleKeeper, app.BankKeeper),
 		shield.NewAppModule(app.ShieldKeeper, app.AccountKeeper, app.BankKeeper),
 		ibc.NewAppModule(app.IBCKeeper),
+		ibctm.AppModule{},
 		params.NewAppModule(app.ParamsKeeper),
 		transferModule,
 		icaModule,
@@ -876,7 +879,7 @@ func (app *ShentuApp) RegisterNodeService(clientCtx client.Context, cfg config.C
 
 // RegisterUpgradeHandlers registers necessary upgrade handlers
 func (app *ShentuApp) RegisterUpgradeHandlers() {
-	app.setUpgradeHandler(app.appCodec, app.IBCKeeper.ClientKeeper)
+	app.setUpgradeHandler(app.appCodec)
 }
 
 // initParamsKeeper init params keeper and its subspaces

app/app_test.go

@@ -4,19 +4,20 @@ import (
 	"fmt"
 	"testing"
 
-	"cosmossdk.io/log"
 	"github.com/stretchr/testify/require"
 
+	"cosmossdk.io/log"
+	abci "github.com/cometbft/cometbft/abci/types"
+
 	dbm "github.com/cosmos/cosmos-db"
 	simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims"
 	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/cosmos/ibc-go/v8/testing/simapp"
 )
 
-func TestSimAppExportAndBlockedAddrs(t *testing.T) {
+func TestShentuAppExportAndBlockedAddrs(t *testing.T) {
 	db := dbm.NewMemDB()
 	logger := log.NewTestLogger(t)
-	app := NewShentuAppWithCustomOptions(t, false, simapp.SetupOptions{
+	app := NewShentuAppWithCustomOptions(t, false, SetupOptions{
 		Logger:  logger.With("instance", "first"),
 		DB:      db,
 		AppOpts: simtestutil.NewAppOptionsWithFlagHome(t.TempDir()),
@@ -38,32 +39,20 @@ func TestSimAppExportAndBlockedAddrs(t *testing.T) {
 		)
 	}
 
-	t.Log(app.AuthKeeper)
-}
+	// finalize block so we have CheckTx state set
+	_, err := app.FinalizeBlock(&abci.RequestFinalizeBlock{
+		Height: 1,
+	})
+	require.NoError(t, err)
 
-func TestSimAppExport(t *testing.T) {
-	db := dbm.NewMemDB()
-	logger := log.NewTestLogger(t)
-	appOpts := simapp.SetupOptions{
-		Logger:  logger.With("instance", "first"),
-		DB:      db,
-		AppOpts: simtestutil.NewAppOptionsWithFlagHome(t.TempDir()),
-	}
-	app := NewShentuAppWithCustomOptions(t, false, appOpts)
+	_, err = app.Commit()
+	require.NoError(t, err)
 
-	for acc := range maccPerms {
-		require.True(
-			t,
-			app.BankKeeper.BlockedAddr(app.AccountKeeper.GetModuleAddress(acc)),
-			"ensure that blocked addresses are properly set in bank keeper",
-		)
-	}
+	// Making a new app object with the db, so that initchain hasn't been called
+	app2 := NewShentuApp(logger.With("instance", "second"), db, nil, true, simtestutil.NewAppOptionsWithFlagHome(t.TempDir()))
+	_, err = app2.ExportAppStateAndValidators(false, []string{}, []string{})
+	require.NoError(t, err, "ExportAppStateAndValidators should not have an error")
 
-	//logger2 := log.NewTestLogger(t)
-	// make a new app object with the db so that initchain hasn't been called
-	//app2 := NewShentuApp(logger2, db, nil, true, simtestutil.NewAppOptionsWithFlagHome(""), baseapp.SetChainID("test"))
-	//_, err := app2.ExportAppStateAndValidators(false, []string{}, []string{})
-	//require.NoError(t, err, "ExportAppStateAndValidators should not have an error")
-	//_, err = app2.ExportAppStateAndValidators(true, []string{}, []string{})
-	//require.NoError(t, err, "ExportAppStateAndValidators for zero height should not have an error")
+	_, err = app2.ExportAppStateAndValidators(true, []string{}, []string{})
+	require.NoError(t, err, "ExportAppStateAndValidators for zero height should not have an error")
 }