Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.12.0 merge #920

Merged
merged 103 commits into from
Nov 9, 2024
Merged

V2.12.0 merge #920

merged 103 commits into from
Nov 9, 2024

Conversation

skyargos
Copy link
Contributor

@skyargos skyargos commented Nov 9, 2024

Closes: #XXX
Related: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@skyargos skyargos marked this pull request as ready for review November 9, 2024 03:09
@skyargos skyargos requested a review from a team as a code owner November 9, 2024 03:09
@skyargos skyargos requested review from haozhan9, yijun-liu-c, 0311xuyang and kevin-yuhh and removed request for a team, haozhan9 and yijun-liu-c November 9, 2024 03:09
@skyargos skyargos enabled auto-merge (rebase) November 9, 2024 03:14
auto-merge was automatically disabled November 9, 2024 03:15

Rebase failed

@skyargos skyargos merged commit e6991b0 into master Nov 9, 2024
27 of 51 checks passed
@skyargos skyargos deleted the v2.12.0-rc0 branch November 9, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants