feat(react-native-storybook): Add native module linking errors

.gitattributes

@@ -1,4 +1,4 @@
-./examples/expo-example/.builds/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
-./examples/expo-example/.builds/android.apk filter=lfs diff=lfs merge=lfs -text
-./examples/expo-example/.builds/preview/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
-./examples/expo-example/.builds/preview/android.apk filter=lfs diff=lfs merge=lfs -text
+./examples/expo-example/builds/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
+./examples/expo-example/builds/android.apk filter=lfs diff=lfs merge=lfs -text
+./examples/expo-example/builds/preview/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
+./examples/expo-example/builds/preview/android.apk filter=lfs diff=lfs merge=lfs -text

.github/workflows/build_and_run_sherlo.yml

@@ -49,13 +49,13 @@ jobs:
 
       - name: Build Android example app
         if: ${{ github.event.inputs.MAKE_BUILDS == 'true' }}
-        run: yarn workspace @sherlo/expo-example android:preview
+        run: yarn workspace @sherlo/expo-example android:build:preview
 
       - name: Upload Android Artifact
         uses: actions/upload-artifact@v2
         with:
           name: android-preview
-          path: examples/expo-example/.builds/preview/android.apk
+          path: examples/expo-example/builds/preview/android.apk
 
   ios_preview_build:
     runs-on: macos-13
@@ -103,13 +103,13 @@ jobs:
 
       - name: Build iOS example app
         if: ${{ github.event.inputs.MAKE_BUILDS == 'true' }}
-        run: yarn workspace @sherlo/expo-example ios:preview
+        run: yarn workspace @sherlo/expo-example ios:build:preview
 
       - name: Upload iOS Artifact
         uses: actions/upload-artifact@v2
         with:
           name: ios-preview
-          path: examples/expo-example/.builds/preview/ios.tar.gz
+          path: examples/expo-example/builds/preview/ios.tar.gz
 
   run_sherlo_action:
     runs-on: ubuntu-latest

.github/workflows/pr_check.yml

@@ -8,16 +8,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+
       - name: Check PR title
         uses: amannn/[email protected]
         with:
           types: |
-            feat
             fix
-            docs
-            chore
-            style
-            refactor
-            perf
-            test
-          pattern: '^(feat|fix|docs|chore|style|refactor|perf|test)(\(.+\))?: .{1,72}'
+            feat
+          scopes: |
+            action
+            cli
+            react-native-storybook
+            expo-example
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

examples/expo-example/.gitattributes

@@ -1,2 +1,2 @@
-.builds/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
-.builds/android.apk filter=lfs diff=lfs merge=lfs -text
+builds/ios.tar.gz filter=lfs diff=lfs merge=lfs -text
+builds/android.apk filter=lfs diff=lfs merge=lfs -text

examples/expo-example/.gitignore

@@ -7,7 +7,7 @@ node_modules/
 .expo/
 dist/
 web-build/
-.builds/sherloexpoexample.app
+builds/sherloexpoexample.app
 
 # Native
 *.orig.*

examples/expo-example/README.md

@@ -44,8 +44,8 @@ To use the `@sherlo/expo-example` package in your project, follow these steps:
 8. **React Native Code Changes**: If you make changes to the React Native code, rebuild the app with the following commands before running visual tests:
 
    ```bash
-   yarn android:preview
-   yarn ios:preview
+   yarn android:build:preview
+   yarn ios:build:preview
    ```
 
    These builds are then uploaded and tested via `npx @sherlo/cli` command.

examples/expo-example/metro.config.js

@@ -1,7 +1,5 @@
-// metro.config.js
 const path = require('path');
 const { getDefaultConfig } = require('expo/metro-config');
-
 const { generate } = require('@storybook/react-native/scripts/generate');
 
 generate({
@@ -11,35 +9,8 @@ generate({
 /** @type {import('expo/metro-config').MetroConfig} */
 const config = getDefaultConfig(__dirname);
 
-// config.resolver.unstable_enablePackageExports = true;
 config.transformer.unstable_allowRequireContext = true;
 
 config.resolver.sourceExts.push('mjs');
 
-// const projectRoot = __dirname;
-// const monorepoRoot = path.resolve(projectRoot, '../..');
-
-// // Only list the packages within your monorepo that your app uses. No need to add anything else.
-// // If your monorepo tooling can give you the list of monorepo workspaces linked
-// // in your app workspace, you can automate this list instead of hardcoding them.
-// const monorepoPackages = {
-//   '@sherlo/react-native-storybook': path.resolve(monorepoRoot, 'packages/react-native-storybook'),
-// };
-
-// // 1. Watch the local app folder, and only the shared packages (limiting the scope and speeding it up)
-// // Note how we change this from `monorepoRoot` to `projectRoot`. This is part of the optimization!
-// config.watchFolders = [projectRoot, ...Object.values(monorepoPackages)];
-
-// // Add the monorepo workspaces as `extraNodeModules` to Metro.
-// // If your monorepo tooling creates workspace symlinks in the `node_modules` folder,
-// // you can either add symlink support to Metro or set the `extraNodeModules` to avoid the symlinks.
-// // See: https://facebook.github.io/metro/docs/configuration/#extranodemodules
-// config.resolver.extraNodeModules = monorepoPackages;
-
-// // 2. Let Metro know where to resolve packages and in what order
-// config.resolver.nodeModulesPaths = [
-//   path.resolve(projectRoot, 'node_modules'),
-//   path.resolve(monorepoRoot, 'node_modules'),
-// ];
-
 module.exports = config;

examples/expo-example/package.json

@@ -4,20 +4,17 @@
   "private": true,
   "main": "index.ts",
   "scripts": {
-    "start": "expo start --dev-client",
-    "android": "adb install .builds/android.apk && expo start --android --dev-client",
-    "android:build": "eas build --platform android --local --profile=development --output=.builds/android.apk",
-    "android:preview": "eas build --platform android --local --profile=preview --output=.builds/preview/android.apk",
-    "ios": "tar -xzvf .builds/ios.tar.gz -C .builds/ && xcrun simctl install booted .builds/sherloexpoexample.app && expo start --ios --dev-client",
-    "ios:build": "eas build --platform ios --local --profile=development --output=.builds/ios.tar.gz",
-    "ios:preview": "eas build --platform ios --local --profile=preview --output=.builds/preview/ios.tar.gz",
-    "update": "eas update --branch preview --message update",
-    "web": "expo start --web",
-    "storybook:web": "storybook dev -p 6006 -c .storybook-web",
-    "build-storybook": "storybook build -c .storybook-web",
+    "android:build:dev": "eas build --platform android --local --profile=development --output=builds/android.apk",
+    "android:build:preview": "eas build --platform android --local --profile=preview --output=builds/preview/android.apk",
+    "android:start:dev": "adb install builds/android.apk && expo start --android --dev-client",
+    "android:start:go": "expo start --android --go",
+    "ios:build:dev": "eas build --platform ios --local --profile=development --output=builds/ios.tar.gz",
+    "ios:build:preview": "eas build --platform ios --local --profile=preview --output=builds/preview/ios.tar.gz",
+    "ios:start:dev": "tar -xzvf builds/ios.tar.gz -C builds/ && xcrun simctl install booted builds/sherloexpoexample.app && expo start --ios --dev-client",
+    "ios:start:go": "expo start --ios --go",
     "sherlo": "sherlo --config sherlo.config.json",
-    "storybook-generate": "sb-rn-get-stories --config-path .storybook",
-    "storybook-watch": "sb-rn-watcher --config-path .storybook"
+    "storybook:web": "storybook dev -p 6006 -c .storybook-web",
+    "storybook:native:generate": "sb-rn-get-stories --config-path .storybook"
   },
   "dependencies": {
     "@expo-google-fonts/urbanist": "^0.2.3",
@@ -28,7 +25,6 @@
     "@shopify/flash-list": "1.6.3",
     "expo": "~50.0.8",
     "expo-app-loading": "^2.1.1",
-    "expo-constants": "^15.4.5",
     "expo-dev-client": "~3.3.9",
     "expo-font": "~11.10.3",
     "expo-linear-gradient": "~12.7.2",

examples/expo-example/sherlo.config.json

@@ -1,7 +1,7 @@
 {
   "projectToken": "<YOUR_PROJECT_TOKEN>",
   "android": {
-    "path": ".builds/preview/android.apk",
+    "path": "builds/preview/android.apk",
     "packageName": "com.sherlo.example",
     "devices": [
       {
@@ -19,7 +19,7 @@
     ]
   },
   "ios": {
-    "path": "./.builds/preview/ios.tar.gz",
+    "path": "./builds/preview/ios.tar.gz",
     "bundleIdentifier": "com.sherlo.example",
     "devices": [
       {