Fix parser regression #2109
Fix parser regression #2109
Conversation
Added exception catch for TypeErrors due to future addition of keys, allowing Sherlock to continue past those errors. Removed $schema to accomodate older versions of the parser. This key will be added back in sherlock-project#2088 (or other version incrementing change).
There was a problem hiding this comment.
Okay, for me, this seems sufficient for now. @ppfeister Thank you for this.
We need to improve our tests later so that this can be caught beforehand in the PRs before merging, thus avoiding breaking anything in older versions. I'll make improvements to that in the future.
|
Oops, looks like I missed something here: https://github.com/sherlock-project/sherlock/actions/runs/8995885403/job/24711519662 |
|
Should just be an ignore-able warning from the try catch. Let me check. |
|
Ahhh there we go. I got it. Stand by. |
|
opened #2110 |
Interesting. Can't imagine that being too difficult to set up. |
|
Added catch for TypeErrors that may be caused due to the future addition of keys (if any ever get added), allowing Sherlock to continue past those errors.
Removed $schema to accomodate older versions of the parser. This key will be added back in after #2088 (or other version incrementing change) is merged, giving users time to update.
@matheusfelipeog or @sdushantha :
Merge is recommended as a hotfix.
PR addresses comments made here. Apparently the old way SitesInformation processed the data.json wasn't too friendly to the new key, so we're removing it for a now.
Fixes #2108