Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Instagram detection method to use error message instead of status_code #2321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alokranjan609
Copy link
Contributor

Summary: This PR updates the detection method for Instagram usernames in Sherlock's data.json file. Previously, Sherlock was relying on the HTTP status code (status_code) to determine whether a username was claimed or unclaimed. However, Instagram now returns an error message instead of a 404 status code for unclaimed usernames. This update switches the detection method to use the error message approach.

Changes Made:

  • Updated the Instagram entry in data.json to:
  1. Change errorType from status_code to message.
  2. Add errorMsg field with the message "Sorry, this page isn't available", which Instagram displays when a username doesn't exist.
  3. Kept the urlProbe field to query Picuki as a backup option for username detection.

Rationale: Instagram no longer returns a 404 Not Found for unclaimed usernames. Instead, it displays an error message. This caused Sherlock's detection to fail when looking for Instagram usernames. By switching to the message detection method, Sherlock can now reliably check for the existence of Instagram usernames.

Testing:

1.Tested with known claimed usernames (e.g., "instagram").
2.Tested with made-up usernames to confirm unclaimed detection (e.g., "nonexistusername123").
3.Results were accurate based on Instagram's current behavior.

Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two unrelated files are being changed, and in a fatally-breaking fashion.

@ppfeister
Copy link
Member

ppfeister commented Nov 1, 2024

Could you explain the need and resolution a bit more? When testing Instagram with the current manifest, it seems to work as expected. Positives are returned as positives and negatives as negatives, at least when testing from here.

Copy link

@Zulu-1540 Zulu-1540 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just go away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants