Fix: false positive detection for Topcoder (#2669) #2684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧠 Pull Request Description
Summary
This PR fixes a false positive for the Topcoder site reported in Issue #2669.
Previously, Sherlock incorrectly detected existing accounts for usernames that did not exist.
Changes Made
Updated the Topcoder username regex pattern in
sherlock/resources/data.json
.Replaced the old pattern:
[a-zA-Z0-9 ]
with the corrected one:
^[A-Za-z0-9 _-]{1,50}$
This ensures proper validation of Topcoder usernames (letters, numbers, underscores, and hyphens within 1–50 characters).
Verification
Related Issue
Closes #2669
Testing Example