Fix GetNameClassWriter errors during remap on JDK11 classes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the remap process for ASM8 supports higher JDKs, remapping fails on some classes because GetNameClassWriter (which only gets the class name) was throwing an error when processing JDK11 classes with newer features like those from org.jgroups:jgroups. Example errors: ``` 2021/05/27 04:24:11 WARN ClassTransformerJarProcessor[main]: Failed to read class org/jgroups/protocols/Locking.class: java.lang.UnsupportedOperationException: This feature requires ASM7 2021/05/27 04:24:11 WARN ClassTransformerJarProcessor[main]: Failed to read class org/jgroups/protocols/SSL_KEY_EXCHANGE$SessionVerifier.class: java.lang.UnsupportedOperationException: This feature requires ASM7 ``` The fix here is to simply change ASM5 to ASM8, the highest stable version / matching version of the current depended-on ASM. Additionally, we change StringReader to use the higher ASM version as well to prevent errors for the `strings` command, but do not make any specific changes to process/display additional strings for the newer features available since ASM5 in ClassVisitor.
|
+1 for merging this, it was invaluable for fixing the linked issue. |
|
@etinquis I think this project is abandoned. I had to do an internal fork with just this commit. |
|
@redcape Yeah it seems like it, but one can only hope 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the remap process for ASM8 supports higher JDKs, remapping fails on some classes because GetNameClassWriter (which only gets the class name) was throwing an error when processing JDK11 classes with newer features like those from org.jgroups:jgroups.
Example errors:
The fix here is to simply change ASM5 to ASM8, the highest stable version / matching version of the current depended-on ASM.
Additionally, we change StringReader to use the higher ASM version as well to prevent errors for the
stringscommand, but do not make any specific changes to process/display additional strings for the newer features available since ASM5 in ClassVisitor.