Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back feat: Support batch receive for consumer. #29

Closed
wants to merge 1 commit into from
Closed

Conversation

shibd
Copy link
Owner

@shibd shibd commented Jun 19, 2023

Master Issue: (todo 274)

Motivation

(todo 274) Support batch receive for the consumer.

Modifications

  • Add batch receive policy config on the consumer.
  • Add batch receive interface on the consumer.
  • Refactor consumer config set and verify logic.
    • Since config set logic with verify logic for the consumer is separate, it will be more complicated to read the code and subsequent extensions.

Verifying this change

  • Add batch receive unit test on Consumer.
  • Add more config verify unit test on Consumer.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd force-pushed the batch_receive branch 2 times, most recently from 22b2f79 to dfb99b1 Compare June 19, 2023 08:44
@shibd shibd changed the title feat: Support batch receive for consumer. back feat: Support batch receive for consumer. Jun 26, 2023
@shibd shibd closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant