normalize usage of docker-compose #774
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change makes it so that macos uses the same compose command as production. this is a "patch" until we can upgrade production. once that's done, then this should be converted to "docker compose" for all platforms. ( the "dash" version is deprecated, but the "space" version doesn't yet exist on production ) i've tested this on apple silicon with local Docker version 26.1.1, build 4cf5afa. and i've tested this previously on my older intel mac with ... a relatively recent version of docker.
|
the very latest version of docker removes the docker-compose command. |
|
I'm trying to get some motion on #772 in the coming weeks to unblock this. This feels like a good "off season" upgrade while we can afford to break production :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change makes it so that macos uses the same "dash" compose command as production. (
docker-compose)this is a "patch" until we can upgrade production. ( re: #772 ) once that's done, then this should be converted to the "space" version (
docker compose)( even though the dash version is deprecated, the "dash" version works on macos with current versions of docker. the "space" version doesn't yet exist on production )
i've tested this on apple silicon with local Docker version 26.1.1, build 4cf5afa. and i've tested this previously on my older intel mac with ... a relatively recent version of docker.
( eta: production is 24.0.5 - 2023-07-24 )
see also this thread from @carrythebanner