Issue/#18/Handle error logging for third party issues #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2019 10:34
RichardWatkins1
approved these changes
Apr 3, 2019
mufudzimasaire
approved these changes
Apr 3, 2019
added 2 commits
April 3, 2019 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address ticket #18
With the fix introduced in #15, errors are being stopped form reported everywhere. And also have noticed that circuit breaker errors are not logged into newrelic.
This PR allows logging into sentry only if
error_logging_enabledis set to true, and errors will be always logged into Newrelic.An example of error being reported after this fix:
https://rpm.newrelic.com/accounts/1488697/applications/62992650/traced_errors/fe78a41a-554f-11e9-9628-0242ac110008_0_8070