-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リリースに sumomo バイナリを含めるようにする #158
Changes from 2 commits
a8cea51
ba26d43
ca6651e
825b725
6ea4e03
79d0085
9edd9c5
89d6227
22db937
0d6bb67
3bee9ea
89d511a
df076ba
b33addf
97a4d38
f87a35d
b66298f
74f312c
7b5afd5
d724f90
6c5f641
46e80f9
5c19bd6
38fc98c
34de507
921a800
875d1cb
b2687ce
83a4559
378ad70
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -348,6 +348,30 @@ jobs: | |
- uses: ./.github/actions/download | ||
with: | ||
platform: android | ||
# Examples のダウンロード | ||
- name: Download Examples | ||
uses: actions/download-artifact@v4 | ||
with: | ||
pattern: examples_* | ||
merge-multiple: false | ||
- name: Archive Examples | ||
run: | | ||
for d in examples_*; do | ||
mkdir -p "archive/$d" | ||
mv "$d" "archive/$d/" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 入力となるディレクトリと、そこから sumomo を取り出して配置するディレクトリが同じ場所にあると分かりにくいので、わざわざ mv しなくて良いです。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mv を削除しました |
||
if [[ "$d" == "examples_macos_arm64" ]]; then | ||
mv "archive/$d/$d/sumomo" "archive/$d/sumomo" | ||
rm -rf "archive/$d/$d" | ||
(cd archive && tar czf "../sumomo_macos_arm64.tar.gz" "$d") | ||
echo "sumomo_macos_arm64.tar.gz" >> package_paths.env | ||
elif [[ "$d" == *"windows"* ]]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. プラットフォーム名に対してこういう曖昧な判定をすると、
という問題があるので、ワイルドカードを使わずに There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. プラットフォームをまとめず一つずつ書くようにしました。 |
||
(cd archive && zip -r "../sumomo_windows_x86_64.zip" "$d") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. このままだと全部の examples バイナリが含まれてそう There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. バイナリ格納方法を見直しました。 |
||
echo "sumomo_windows_x86_64.zip" >> package_paths.env | ||
else | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ここも同じ問題があるので、意図したプラットフォームを全部列挙して、意図しないプラットフォーム名が来たらエラーになるようにして下さい There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. バイナリを作りたいプラットフォームを書くようにし、意図しないものは無視するようにしました。 |
||
(cd archive && tar czf "../sumomo_${d#examples_}.tar.gz" "$d") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. このままだと全部の examples バイナリが含まれてそう There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. バイナリ格納方法を見直しました。 |
||
echo "sumomo_${d#examples_}.tar.gz" >> package_paths.env | ||
fi | ||
done | ||
- name: Env to output | ||
run: | | ||
echo "package_paths<<EOF" >> $GITHUB_OUTPUT | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d
という名前が分かりにくいのでちゃんとした名前を指定して下さい。また、ワイルドカードで列挙すると一覧性が悪くなるので、以下のようにして下さい。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d
を使用することをやめました。