Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sora C++ SDK を 2024.8.0-canary.33 に上げる #44

Merged
merged 5 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/checkout@v4
- name: Install deps
run: |
DEBIAN_FRONTEND=noninteractive sudo apt-get -y install libva-dev libdrm-dev libx11-dev libxext-dev
DEBIAN_FRONTEND=noninteractive sudo apt-get -y install libx11-dev libxext-dev
- run: python3 run.py ${{ matrix.name }} --package
- name: Get package name
shell: bash
Expand Down
16 changes: 11 additions & 5 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@
- @torikizi
- [CHANGE] FakeNetwork 系の機能を削除
- @melpon
- [UPDATE] CMakeLists の依存から libva と libdrm を削除する
- @zztkm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libva と libdrm を削除しても既存のシステムは壊れないと思うので、CHANGE では無さそう

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4d59593 で UPDATE に修正しました。

- [UPDATE] CI の Ubuntu で libba と libdrm をインストールしないようにする
- [UPDATE] Sora C++ SDK を `2024.8.0` に上げる
- それに伴って以下のライブラリのバージョンも上げる
- libwebrtc のバージョンを `m128.6613.2.0` に上げる
- Boost のバージョンを `1.86.0` に上げる
- CMake のバージョンを `3.30.3` に上げる
- libwebrtc のバージョンを `m132.6834.4.0` に上げる
- Boost のバージョンを `1.87.0` に上げる
- CMake のバージョンを `3.30.5` に上げる
- OpenH264 のバージョンを `2.5.0` に上げる
- `#include <rtc_base/helpers.h>` を `#include <rtc_base/crypto_random.h>` に置き換える
- `boost::json::error_code` を `boost::system::error_code` に置き換える
- @melpon @voluntas
- `absl::nullopt` を `std::nullopt` に置き換える
- `boost::optional` を std::optional` に置き換える
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

` 足りてない (develop で直します)

- @melpon @voluntas @zztkm
- [UPDATE] Blend2D, AsmJit を最新版に上げる
- @melpon, torikizi
- @melpon, @torikizi
- [ADD] Ubuntu 24.04 のビルドを追加
- @melpon

Expand Down
5 changes: 0 additions & 5 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ find_package(Blend2D REQUIRED)
find_package(CLI11 REQUIRED)
find_package(yaml-cpp REQUIRED)

if (ZAKURO_PLATFORM STREQUAL "ubuntu-20.04_x86_64" OR ZAKURO_PLATFORM STREQUAL "ubuntu-22.04_x86_64" OR ZAKURO_PLATFORM STREQUAL "ubuntu-24.04_x86_64")
find_package(Libva REQUIRED)
find_package(Libdrm REQUIRED)
endif()

add_executable(zakuro)

set_target_properties(zakuro PROPERTIES CXX_STANDARD 17 C_STANDARD 17)
Expand Down
10 changes: 5 additions & 5 deletions VERSION
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
ZAKURO_VERSION=2024.2.0-canary.2
SORA_CPP_SDK_VERSION=2024.8.0-canary.3
WEBRTC_BUILD_VERSION=m128.6613.2.0
BOOST_VERSION=1.86.0
SORA_CPP_SDK_VERSION=2024.8.0-canary.33
WEBRTC_BUILD_VERSION=m132.6834.4.0
BOOST_VERSION=1.87.0
CLI11_VERSION=v2.4.2
CMAKE_VERSION=3.30.3
CMAKE_VERSION=3.30.5
BLEND2D_VERSION=ca5403c1d02b2bc9d2de581e4cb13e5e80f33860
ASMJIT_VERSION=2e93826348d6cd1325a8b1f7629e193c58332da9
OPENH264_VERSION=v2.4.1
OPENH264_VERSION=v2.5.0
YAML_CPP_VERSION=0.8.0
2 changes: 1 addition & 1 deletion src/nop_video_decoder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ int32_t NopVideoDecoder::Decode(const webrtc::EncodedImage& input_image,
.set_video_frame_buffer(i420_buffer)
.set_timestamp_rtp(input_image.RtpTimestamp())
.build();
callback_->Decoded(decoded_image, absl::nullopt, absl::nullopt);
callback_->Decoded(decoded_image, std::nullopt, std::nullopt);

return WEBRTC_VIDEO_CODEC_OK;
}
Expand Down
6 changes: 2 additions & 4 deletions src/util.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
#include <boost/filesystem/operations.hpp>
#include <boost/filesystem/path.hpp>
#include <boost/json.hpp>
#include <boost/optional.hpp>
#include <boost/optional/optional_io.hpp>
#include <boost/preprocessor/stringize.hpp>

// WebRTC
Expand Down Expand Up @@ -85,8 +83,8 @@ void Util::ParseArgs(const std::vector<std::string>& cargs,
auto bool_map = std::vector<std::pair<std::string, bool>>(
{{"false", false}, {"true", true}});
auto optional_bool_map =
std::vector<std::pair<std::string, boost::optional<bool>>>(
{{"false", false}, {"true", true}, {"none", boost::none}});
std::vector<std::pair<std::string, std::optional<bool>>>(
{{"false", false}, {"true", true}, {"none", std::nullopt}});

app.add_option("--name", config.name, "Client Name");
app.add_option("--vcs", config.vcs, "Virtual Clients (default: 1)")
Expand Down
6 changes: 3 additions & 3 deletions src/zakuro.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ struct ZakuroConfig {
std::string sora_audio_codec_type = "";
// Lyra 用の設定
int sora_audio_codec_lyra_bit_rate = 0;
boost::optional<bool> sora_audio_codec_lyra_usedtx;
std::optional<bool> sora_audio_codec_lyra_usedtx;
bool sora_check_lyra_version = false;
// 0 の場合ビットレートは Sora 側で決める
int sora_video_bit_rate = 0;
Expand All @@ -67,9 +67,9 @@ struct ZakuroConfig {
int sora_spotlight_number = 0;
std::string sora_spotlight_focus_rid;
std::string sora_spotlight_unfocus_rid;
boost::optional<bool> sora_data_channel_signaling;
std::optional<bool> sora_data_channel_signaling;
int sora_data_channel_signaling_timeout = 180;
boost::optional<bool> sora_ignore_disconnect_websocket;
std::optional<bool> sora_ignore_disconnect_websocket;
int sora_disconnect_wait_timeout = 5;
boost::json::value sora_metadata;
boost::json::value sora_signaling_notify_metadata;
Expand Down