fix: fixed the audio file escape name issue (#75)

* fix: fixed the audio file escape name issue * fix: fixed file name escape issue * feat: generated v1.5.1 executable for win32 --------- Co-authored-by: Hanxiong Shi <[email protected]>
shihanxiong · Apr 17, 2023 · bfe874c · bfe874c
1 parent 1bcdb16
commit bfe874c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -4,6 +4,7 @@
 
 - application now disables play / pause buttons to dis-allow double clicking
 - fixed the issue where removing audio preview is not allowed once audio mixer is loaded
+- fixed the issue when filenames are not escaped while generating audios
 
 ### v1.5.0
 

diff --git a/src/audio_utils.py b/src/audio_utils.py
@@ -1,5 +1,6 @@
 import subprocess
 import logging
+from file_utils import FileUtils
 
 
 class AudioUtils():
@@ -9,7 +10,7 @@ def __init__(self):
     @staticmethod
     def generate_mp3_from_mp4(mp4_input_filename, mp3_output_filename, ffmpeg_preset_arg="-preset ultrafast"):
         # using preset = ultrafast as the audio is for preview only
-        cmd = f"ffmpeg -i {mp4_input_filename} -vn -preset ultrafast -acodec mp3 {ffmpeg_preset_arg} {mp3_output_filename}"
+        cmd = f"ffmpeg -i {mp4_input_filename} -vn -preset ultrafast -acodec mp3 {ffmpeg_preset_arg} {FileUtils.escape_file_name(mp3_output_filename)}"
         subprocess.check_output(cmd, shell=True)
         # TODO: do logging via status_component instead
         logging.debug(
@@ -19,7 +20,7 @@ def generate_mp3_from_mp4(mp4_input_filename, mp3_output_filename, ffmpeg_preset
 
     @staticmethod
     def generate_aac_from_mp4(mp4_input_filename, aac_output_filename, ffmpeg_preset_arg):
-        cmd = f"ffmpeg -i {mp4_input_filename} -vn -acodec copy {ffmpeg_preset_arg} {aac_output_filename}"
+        cmd = f"ffmpeg -i {mp4_input_filename} -vn -acodec copy {ffmpeg_preset_arg} {FileUtils.escape_file_name(aac_output_filename)}"
         subprocess.check_output(cmd, shell=True)
 
         return aac_output_filename
diff --git a/src/dist/win32_video_loom_1_5_1.exe b/src/dist/win32_video_loom_1_5_1.exe