-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes by create-pull-request action #44
base: master
Are you sure you want to change the base?
Conversation
UpdateConditionRequest 的更新类图classDiagram
class UpdateConditionRequest {
Error string
Id string
Metric string
Op string
}
note for UpdateConditionRequest.Metric "Metric string. Following metrics are forbidden:\nnew_security_hotspots, security_hotspots, alert_status"
ComponentTreeRequest 的更新类图classDiagram
class ComponentTreeRequest {
Asc string
Branch string
Component string
MetricKeys string
MetricPeriodSort string
MetricSort string
MetricSortFilter string
}
note for ComponentTreeRequest.MetricKeys "MetricKeys string. For type DATA only security_issues, new_reliability_issues, new_security_issues, new_maintainability_issues, reliability_issues, maintainability_issues metrics are supported"
文件级别变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的 仪表板 以:
获得帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request reorders the lists of forbidden metrics for quality gate conditions and supported metrics for the ComponentTreeRequest to ensure consistency. Updated class diagram for CreateConditionRequestclassDiagram
class CreateConditionRequest {
Error string
GateName string
Metric string
Op string
}
note for CreateConditionRequest.Metric "Metric string. Following metrics are forbidden:\nnew_security_hotspots, security_hotspots, alert_status"
Updated class diagram for UpdateConditionRequestclassDiagram
class UpdateConditionRequest {
Error string
Id string
Metric string
Op string
}
note for UpdateConditionRequest.Metric "Metric string. Following metrics are forbidden:\nnew_security_hotspots, security_hotspots, alert_status"
Updated class diagram for ComponentTreeRequestclassDiagram
class ComponentTreeRequest {
Asc string
Branch string
Component string
MetricKeys string
MetricPeriodSort string
MetricSort string
MetricSortFilter string
}
note for ComponentTreeRequest.MetricKeys "MetricKeys string. For type DATA only security_issues, new_reliability_issues, new_security_issues, new_maintainability_issues, reliability_issues, maintainability_issues metrics are supported"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @shijl0925 - 我已经查看了你的更改 - 这里有一些反馈:
总体评论:
- 看起来你只是在重新排序禁止指标列表和支持的数据类型列表中的项目 - 这样做有什么原因吗?
以下是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请点击每个评论上的👍或👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @shijl0925 - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're just reordering the items in the lists of forbidden metrics and supported data types - is there a reason for this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fb49033
to
76b8a2f
Compare
76b8a2f
to
d0e5e3b
Compare
|
Automated changes by create-pull-request GitHub action